Project

General

Profile

Actions
Copy link

Feature #1442

open

API: CORS Settings in Backend UI

Added by Bernhard Koschiček-Krombholz over 2 years ago. Updated 4 months ago.

Status:
Acknowledged
Priority:
Normal
Assignee:
-
Category:
API
Target version:
7.15.0
Start date:
2021-01-07
Estimated time:

Description

For the new version of the API, the CORS settings moved also a little bit. I changed it from a decorator to specific path mapping (/api/*). The CORS options are in /openatlas/api/v02/routes.py and are initialized with the app: 

cors = CORS(app, resources={r"/api/*": {"origins": app.config['CORS_ALLOWANCE']}})

This ticket is the remainder, that more API options should make it to the backend (Like ALLOWED_IPS)

Related issues 2 (1 open — 1 closed)

Related to OpenAtlas - Feature #1299: API: Setting for CORS allowance in UI ClosedBernhard Koschiček-Krombholz2020-07-07Actions
Related to OpenAtlas - Feature #1828: Move image size config to backendAcknowledged2023-01-16Actions
Actions
Copy link
 #1

Updated by Bernhard Koschiček-Krombholz over 2 years ago

  • Related to Feature #1299: API: Setting for CORS allowance in UI added
Actions
Copy link
 #2

Updated by Alexander Watzinger over 1 year ago

  • Subject changed from CORS Settings in Backend UI to API: CORS Settings in Backend UI
  • Status changed from New to Acknowledged
Actions
Copy link
 #3

Updated by Alexander Watzinger about 1 year ago

  • Category set to API
Actions
Copy link
 #4

Updated by Alexander Watzinger 4 months ago

  • Target version changed from Wishlist to 7.15.0
  • Tracker changed from Feature to Question
  • Status changed from Acknowledged to Assigned
  • Assignee set to Bernhard Koschiček-Krombholz

We talked yesterday about removing this issue but I checked today and there is a CORS setting in default.py.

CORS_ALLOWANCE = '*'  # Cross-Origin source (CORS)

Shouldn't we move this to the backend configuration (configurable via the UI) or isn't it needed/used anymore (than we should delete it in default.py) or did I miss something?

Actions
Copy link
 #5

Updated by Bernhard Koschiček-Krombholz 4 months ago

You are right, we should implement this.

Actions
Copy link
 #6

Updated by Alexander Watzinger 4 months ago

  • Status changed from Assigned to Acknowledged
  • Assignee deleted (Bernhard Koschiček-Krombholz)
  • Target version changed from 7.15.0 to 7.12.0
Actions
Copy link
 #7

Updated by Alexander Watzinger 4 months ago

  • Related to Feature #1828: Move image size config to backend added
Actions
Copy link
 #8

Updated by Alexander Watzinger 4 months ago

  • Tracker changed from Question to Feature
Actions
Copy link
 #9

Updated by Alexander Watzinger 4 months ago

  • Assignee set to Alexander Watzinger
  • Status changed from Acknowledged to In Progress
Actions
Copy link
 #10

Updated by Alexander Watzinger 4 months ago

  • Related to deleted (Feature #1828: Move image size config to backend)
Actions
Copy link
 #11

Updated by Alexander Watzinger 4 months ago

  • Related to Feature #1828: Move image size config to backend added
Actions
Copy link
 #12

Updated by Alexander Watzinger 4 months ago

  • Target version changed from 7.12.0 to 7.15.0

Because this too is related to the new frontend system, this issue is moved to a later version also.

Actions
Copy link
 #13

Updated by Alexander Watzinger 4 months ago

  • Status changed from In Progress to Acknowledged
  • Assignee deleted (Alexander Watzinger)
Actions
Copy link

Also available in: Atom PDF